[AppBar] Add support for position="sticky"
#10090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to run |
mbrookes
reviewed
Jan 29, 2018
src/AppBar/AppBar.js
Outdated
| @@ -91,7 +98,7 @@ AppBar.propTypes = { | |||
| /** | |||
| * The positioning type. | |||
There was a problem hiding this comment.
It would be good to briefly describe the different options.
mbrookes
approved these changes
Jan 29, 2018
mbrookes
added
component: app bar
|
@scottastrophic Thank you for this first time pull-request :). |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10085. I added sticky in all the places I could find that reference the
AppBarpositioning and reordered them consistently. Since sticky acts like a combination of static and fixed, I figured it should have the additional CSS rules for both, but not 100% sure on that point.